WIP: Byte pattern #3979
Draft
WIP: Byte pattern #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Pattern.captureAs which will act just like capture, but additionally takes an `a` which will be used as a replacement for the capture. My motivation for adding it is that I want to match on escape sequence, but actually capture the unescaped character instead. For example: ``` Pattern.captureAs "\n" (Pattern.literal "\\n") ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Pattern BytesOverview
add support for constructing
Patterns overBytesImplementation notes
Genericized
PatternandCPattern.Patternnow takes two type parameters, one is the type likeBytesorTextand one is the type which is going to contain all the character class like things, right now it isCharPatternwhich lets you do things like "range" and "set" and "not" and "any". bytes will be largely similar.Interesting/controversial decisions
Test coverage
not yet
Loose ends
TBD