Autocomplete for scratch.u definition names #3874
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Jul 19, 2023
There was a problem hiding this comment.
No changes here, just moved to fix cyclic imports
ChrisPenner
commented
Jul 19, 2023
| @@ -97,6 +98,7 @@ checkFile doc = runMaybeT $ do | |||
| & toRangeMap | |||
| let fileSummary = mkFileSummary parsedFile typecheckedFile | |||
| let tokenMap = getTokenMap tokens | |||
| let fileCompletions = fromMaybe mempty ((namesToCompletionTree . UF.typecheckedToNames <$> typecheckedFile) <|> (namesToCompletionTree . UF.toNames <$> parsedFile)) | |||
There was a problem hiding this comment.
This is the line that actually computes the new completions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently auto-complete only includes definitions are checked into the codebase, so it won't include any new definitions in the file. This PR adds local definitions to autocomplete.
Implementation notes
The actual addition of the names is trivial, but it's not useful to only include these names when the file is parsing/typechecking since auto-complete is usually triggered while typing in an invalid state, so we add a new
FileAnalysisTripletype which includes:So I make some changes to the LSP's update loop to keep track of those.
Test coverage
Manual testing