-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for compiling NetBSD & OpenBSD #851
Draft
craciunoiuc
wants to merge
2
commits into
unikraft:staging
Choose a base branch
from
craciunoiuc:craciunoiuc/add-openbsd-netbsd
base: staging
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Add support for compiling NetBSD & OpenBSD #851
craciunoiuc
wants to merge
2
commits into
unikraft:staging
from
craciunoiuc:craciunoiuc/add-openbsd-netbsd
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
added
kind/enhancement
New feature or request
area/machine
Issue or PR is related to KraftKit's machine instance subsystem
labels
Oct 2, 2023
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Update: I think NetBSD works now but I would keep this PR together
|
craciunoiuc
force-pushed
the
craciunoiuc/add-openbsd-netbsd
branch
from
May 27, 2024 09:54
0706fa8
to
580d3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/machine
Issue or PR is related to KraftKit's machine instance subsystem
kind/enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmt
on your commit series before opening this PR;Description of changes
Similar to the FreeBSD PR #603 this adds support for OpenBSD and NetBSD.
Unfortunately, right now, because of a dependency bug in
containerd
this fails to compile. The fix seems simple, but it is up to them to fix right now. The errors are like following.For OpenBSD:
For NetBSD:
As such, we mark this as Draft until it is ready.