feat: Add Xen support #1240
Draft
feat: Add Xen support #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistan26
commented
Feb 21, 2024
Comment on lines
+67
to
+71
| for { | ||
| if peekAndRead(f, reader, &logs, &errs) { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
We can get multi-line writes with one event triggered.
IMO something better would be for peekAndRead to look ahead for the last newline so we end up with a single write.
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
f32e678
to
9b5e55a
Compare
andreistan26
changed the title
xen support for kraftkitXen support
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
4726be4
to
c67465b
Compare
craciunoiuc
requested changes
Apr 16, 2024
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
cb8812c
to
96a6886
Compare
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
029891f
to
08c224c
Compare
craciunoiuc
requested changes
May 8, 2024
| python3-wheel \ | ||
| uuid-dev; \ | ||
| pip3 install python-config --break-system-packages; \ | ||
| git clone -b stable-4.18 https://xenbits.xen.org/git-http/xen.git /xen; \ |
There was a problem hiding this comment.
can you turn this version into an ARG?
Suggested change
| git clone -b stable-4.18 https://xenbits.xen.org/git-http/xen.git /xen; \ | |
| git clone -b stable-${XEN_VERSION} https://xenbits.xen.org/git-http/xen.git /xen; \ |
| if opts.Follow && machine.Status.State == machineapi.MachineStateRunning { | ||
|
|
||
| // Sometimes the kernel can boot and exit faster than we can start tailing the logs | ||
| if opts.Follow && (machine.Status.State == machineapi.MachineStateRunning || machine.Status.State == machineapi.MachineStateExited) { |
There was a problem hiding this comment.
Break this up on multiple lines
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
c517ef1
to
77bcc05
Compare
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
In the case of Xen, on fast applications, the logs would have been called when the machine was already in the exit state. Signed-off-by: Andrei Stan <andreistan2003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
GitHub-Closes: #990