fix(paraprogress): Do not quit on receiving 100% progress #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may pre-emptively shutdown the process. Instead, let the process exit "naturally". If the process is reporting via the onProgress-callback 100%, then this a mistake of the use of the callback itself, and the user will simply have to wait beyond the 100% until the process exits. There is now also a `WithTimeout` option so we can have both graceful and non- graceful exits with this package. Signed-off-by: Alexander Jung <alex@unikraft.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This may pre-emptively shutdown the process. Instead, let the process exit "naturally". If the process is reporting via the onProgress-callback 100%, then this a mistake of the use of the callback itself, and the user will simply have to wait beyond the 100% until the process exits. There is now also a
WithTimeoutoption so we can have both graceful and non-graceful exits with this package.