Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to avoid
notdirty_write
as much as possible. Please refer to #1838 for the context.If there is no TB in the page, we can skip the slow path, so mark the TLB as
dirty
in such case. AndPageDesc
is allocated only when TB is generated, so we can apply the same logic for the case wherePageDesc
is not found.If Unicorn generates a TB, we have to take the slow path for the page. In
tb_page_add
, if it's the first tb generated,tlb_protect_code
will be called, and it will callcpu_physical_memory_test_and_clear_dirty
. In this function, we reset the dirty flag so that Unicorn callsnotdirty_write
when memory is overwritten in the page.Tested with
tests/regress/x86_self_modifying.py
.