Windows specific fixes for npm + js builds and testing #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's probably a \ vs / problem.
new URL('dist', import.meta.url).pathname doesn't work for Windows. After futzing around with different approaches, I found the simplest was just removing file:/// from the full href.
I'd be curious to know if this works on other systems, and I'm open to workshopping a cross-platform solution if not!
robertbastian
requested changes
May 16, 2024
There was a problem hiding this comment.
this is generated code so you cannot make changes to it without failing CI (which checks for consistency).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit is from ambiguousname/diplomat@587865a (it also has an associated pull request in rust-diplomat/diplomat#474)
In this repo specifically, I found an issue with
webpack.config.js:It's probably a \ vs / problem.
new URL('dist', import.meta.url).pathname doesn't work for Windows. After futzing around with different approaches, I found the simplest was just removing file:/// from the full href.
I'd be curious to know if this works on other systems, and I'm open to workshopping a cross-platform solution if not!