Try adding compiled data for icu::experimental::transliterate #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested changes
May 14, 2024
There was a problem hiding this comment.
It doesn't work because there is still no transliteration data in CLDR-JSON. CLDR-16720 keeps getting punted.
|
There doesn't appear to be much of value in this PR so I will close it. Backed up at https://github.com/sffc/omnicu/tree/archive/transliterate-compiled-data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4890 (not yet)
@robertbastian I added
transliterate/rules@1toicu::experimental::provider::KEYS. I expectedcargo make bakeddata experimentalto "just work", but it doesn't include the auxiliary keys. Why not?