Make insert_non_basic_units a method
#4805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
changed the title
ConverterFactory to its classinsert_non_basic_units a method
| @@ -38,6 +38,21 @@ impl From<Sign> for num_bigint::Sign { | |||
| } | |||
| } | |||
|
|
|||
| /// A struct that contains the sum and difference of base unit powers. | |||
There was a problem hiding this comment.
nit: keep this in the method
There was a problem hiding this comment.
unfortunatley, it is used as output that is used in other places
Notice: map: &mut LiteMap<u16, PowersInfo>,
There was a problem hiding this comment.
I don't think this PR is worth it then. insert_non_basic_units is an implementation detail of is_reciprocal, and PowersInfo is an implementation detail of that. Having them both at the top level is not well encapsulated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.