Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU4X: Adding list format testing #229

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

sven-oly
Copy link
Collaborator

Add another field list_type. The field "type" in list_fmt data is now deprecated.

@sven-oly
Copy link
Collaborator Author

Almost all work. Locale und fails.

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks about right

@sffc
Copy link
Member

sffc commented May 15, 2024

Please run cargo fmt to satisfy the CI.

@sven-oly sven-oly merged commit bfed07f into unicode-org:main May 20, 2024
6 checks passed
@sven-oly sven-oly deleted the icu4x_list_fmt branch May 28, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants