Use Headless Chrome over PhantomJS for (QUnit) tests #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basic reporter added: |
backflip
changed the title
…|scroll)' over just 'estatico.events.(resize|scroll)'
backflip
commented
Nov 27, 2017
| @@ -57,7 +57,7 @@ class WindowEventListener { | |||
|
|
|||
| // Save to global namespace | |||
| $.extend(true, estatico, { events: {} }); | |||
| estatico.events[eventName] = debouncedEventName; | |||
| estatico.events[debouncedEventName.split('.')[0]] = debouncedEventName; | |||
There was a problem hiding this comment.
This is necessary if we want to have both debounced and throttled variants of scroll/resize. Otherwise the one registered later will overwrite the first one. That's what led to the slideshow tests failing.
I have updated docs/Coding_Guidelines.md accordingly.
Is this a breaking change for anyone?
backflip
changed the title
|
Added to new implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
js:qunitTODO:
js:testsince it will also check for console.error unrelated to specific QUnit tests