feat(estatico-sass): add custom importer for CSS files #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Chore] Fixed failing tests
…unic#61) * [Chore] estatico-boilerplate: Optimized global client-side namespace * [Chore] estatico-boilerplate: Changed module class name
…ing in boilerplate, refactored styles accordingly
Enable Stylelint
* [Change] estatico-boilerplate: Removed jQuery * [Chore] estatico-qunit/estatico-svgsprite: Rewrote client-side code to remove ES2015 features * [Fix] estatico-boilerplate: Added missing polyfills for IE11 * [Change] estatico-eslint: Added default config, added babel-eslint as parser
… estatico-stylelint config accordingly
Jest: Add puppeteer launch args for CI
- @unic/estatico-boilerplate@1.5.0 - @unic/estatico-jest@0.2.0 - @unic/estatico-json-schema@0.2.0 - @unic/estatico-puppeteer@0.0.14 - @unic/estatico-qunit@0.0.10 - @unic/estatico-sass@0.0.14 - @unic/estatico-watch@0.0.12 - @unic/estatico-webpack@0.0.20
- @unic/estatico-boilerplate@1.5.1
- @unic/estatico-boilerplate@1.5.2 - @unic/estatico-jest@0.2.1
- @unic/estatico-boilerplate@1.5.3 - @unic/estatico-jest@0.2.2
- @unic/estatico-boilerplate@1.5.4 - @unic/estatico-jest@0.2.3
- @unic/estatico-boilerplate@1.5.5 - @unic/estatico-jest@0.2.4
|
Christian Sany seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
backflip
commented
Dec 12, 2018
| @@ -6,7 +6,7 @@ | |||
|
|
|||
|
|
|||
| // Reset / normalize styles | |||
| @import "../../../node_modules/normalize.css/normalize"; | |||
| @import "../../../node_modules/normalize.css/normalize.css"; | |||
There was a problem hiding this comment.
The importer only works for files ending with .css
backflip
commented
Dec 12, 2018
| @@ -263,10 +262,6 @@ gulp.task('css', () => { | |||
| './src/', | |||
| './src/assets/css/', | |||
| ], | |||
| importer: [ | |||
There was a problem hiding this comment.
I moved the JSON importer to the task so we don't need it in the boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the
DEPRECATION WARNING Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass. Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.Instead of using the external plugin mentioned in #45, I went for a solution where we don't have to add a
CSS:prefix to the import.While being at it, I had to fix most tests since they broke after an update to
fancy-log