[Change] estatico-svgsprite: Updated loader #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Chore] Fixed failing tests
…#61) * [Chore] estatico-boilerplate: Optimized global client-side namespace * [Chore] estatico-boilerplate: Changed module class name
…ing in boilerplate, refactored styles accordingly
Enable Stylelint
* [Change] estatico-boilerplate: Removed jQuery * [Chore] estatico-qunit/estatico-svgsprite: Rewrote client-side code to remove ES2015 features * [Fix] estatico-boilerplate: Added missing polyfills for IE11 * [Change] estatico-eslint: Added default config, added babel-eslint as parser
… estatico-stylelint config accordingly
…dlebars only on-demand
estatico-json-schema: Added task to validate input data against JSON schema
[Update] estatico-font-datauri: Added rename option
Add .editorconfig to boilerplate
Update async polyfill loading and add unified package for polyfills
|
Christian Sany seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
We are re-activating development on estatico-nou. I am working on a branch to fix the tests so builds pass. If you want this PR merged after the tests are fixed. Please say so. Otherwise it will be closed and the branch will be removed. Gruess, |
|
Hey @lbsonley, I would apply this fix. IMHO the last 3 commits are relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
display:noneinstead of visually hidden (thanks to @FabianEllenberger for pointing this out)