Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] estatico-handlebars: Optimize rebuild behavior #34

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

backflip
Copy link
Collaborator

@backflip backflip commented Mar 29, 2018

Although we have a dependency graph for templates, the rebuilding isn't ideal:

  • Let's assume we have a module which is included in many other modules and pages
  • We are currently working on this module and viewing its preview page in the browser
  • We are editing its template and want to see the result
  • However, depending on how the files are streamed through the html build task, we might have to wait for all dependent modules and pages to be rebuilt until our preview page is taken care of

This PR introduces the following changes:

  • We keep track of the currently viewed page in the browser
  • We prioritize the rebuild of this page by putting it in front of the stream
  • We immediately reload the browser when it has been rebuilt
  • The remaining modules and pages are rebuilt in the background

@backflip backflip changed the title estatico-handlebars: Optimize rebuild behavior [WIP] estatico-handlebars: Optimize rebuild behavior May 7, 2018
@backflip backflip changed the base branch from master to develop September 15, 2018 16:20
@lbsonley
Copy link
Collaborator

We are re-activating development on estatico-nou. I am working on a branch to fix the tests so builds pass. If you want this PR merged after the tests are fixed. Please say so. Otherwise it will be closed and the branch will be removed.

Gruess,
Ben

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants