Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/yarn-workspaces #103

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

robinloeffel
Copy link
Contributor

  • switch out lerna in favor of yarn workspaces
  • remove unnecessary dependencies
  • remove unnecessary config files
  • clean up metadata and file structure

@robinloeffel robinloeffel changed the title Feature/yarn workspaces [wip] feature/yarn-workspaces Jan 22, 2021
@robinloeffel robinloeffel changed the title [wip] feature/yarn-workspaces feature/yarn-workspaces Jan 28, 2021
Copy link
Collaborator

@lbsonley lbsonley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check travis build logs for graphicmagick related error. Add it back to travis.yml if needed

before_install:
- sudo apt-get update
- sudo apt-get install graphicsmagick
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to install graphicsmagick for the image optimization task.

@@ -1,15 +1,14 @@
language: node_js

node_js:
- "14"
Copy link
Collaborator

@lbsonley lbsonley Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider adding multiple node versions here. Travis will do a build for each version listed. I think we should keep all LTS versions of node here. This way we can say we support LTS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's go for 12.x and 14.x

@lbsonley
Copy link
Collaborator

@robinloeffel , I forgot to bump the engines prop in package.json everywhere when I did the node upgrade. Since we are updating the travis config for node version, I think we should bump the engines field for all packages.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robin Löffel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants