Feature/fix tests #102
Open
Feature/fix tests #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: decouples method from test library. compare now returns a boolean value instead of applying test assertions.
bump estatico-utils dependencyversion
bump estatico-utils version
bump estatico-utils dependency version
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-utils dependency
bump estatico-boilerplate patch version because of devDependencies major version upgrades
Conflicts: .travis.yml packages/estatico-sass/package.json
| @@ -1,5 +1,7 @@ | |||
| language: node_js | |||
| node_js: | |||
| - "10" | |||
There was a problem hiding this comment.
didn't we say only 12 and 14?
| test.afterEach(() => del(path.join(__dirname, '/results'))); | ||
|
|
||
| test('default', t => new Promise((resolve) => { | ||
| task(defaults)() |
There was a problem hiding this comment.
can we re-write this to something less condensed? this is kinda hard to read.
const result = task(defaults);
result().on('finish', () => { ... });would work, too, right?
| @@ -1,3 +1,4 @@ | |||
| // TODO => Get postcss plugin working properly. Currently not prefixing or minifying as expected. | |||
There was a problem hiding this comment.
can you try that after merging dev into this branch? i've cleaned up estatico-sass quite a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make tests pass
refactor out test.cb()
remove side effects from estatico-utils test.compareFiles method