Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRINGE]: Replace master/slave references #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unclecheese
Copy link
Owner

Embarrassing and gross. Let's get this merged as soon as possible and set fire to all the previous commits. Thanks.

@NightJar
Copy link
Contributor

Site won't load anymore, sorry
PHP Parse error: syntax error, unexpected token "(" in unclecheese/display-logic/src/Criterion.php on line 86

@chrispenny
Copy link
Collaborator

I think this would be a breaking change (protected is technically part of the API). Thankfully I was already planning a new major for Silverstripe 5, so I'll pick this up again as part of #152

@GuySartorelli
Copy link

Property names are part of the API as of PHP 8 as well, FYI. Another reason it should be done in a major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants