Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Hide/Unhide convo, with smart ConvoList updates #445

Merged
merged 1 commit into from May 13, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented May 11, 2024

What does this PR do?

Support for Hiding and Unhiding Convo based on its previous status.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

@BlankParticle BlankParticle marked this pull request as ready for review May 11, 2024 07:22
Copy link

graphite-app bot commented May 11, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (05/11/24)

1 assignee was added to this PR based on Rahul Mishra's automation.

@BlankParticle BlankParticle changed the title feat: Support for Hide/Unhide convo, list update on hide only (for now) feat: Support for Hide/Unhide convo, with smart ConvoList updates May 11, 2024
McPizza0
McPizza0 previously approved these changes May 13, 2024
@BlankParticle BlankParticle changed the base branch from feat/convo-side-bar to main May 13, 2024 12:58
@BlankParticle BlankParticle dismissed McPizza0’s stale review May 13, 2024 12:58

The base branch was changed.

Copy link
Member Author

BlankParticle commented May 13, 2024

Merge activity

  • May 13, 8:59 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 13, 1:56 PM EDT: @BlankParticle merged this pull request with Graphite.

@BlankParticle BlankParticle merged commit 2afbee9 into main May 13, 2024
5 checks passed
@BlankParticle BlankParticle deleted the feat/hide-unhide-convo branch May 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants