Respect backoffice login returnPath regression #16049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #15686 (was originally fixed in 2022/2023)
Description
See issue for detailed info and how to reproduce.
Looks like while implementing the new login screen a typo was made that means the redirect url is never carried on.
There is however another part to this: in some situations when you try to directly go to a protected backoffice page (e.g.
/umbraco#/settings
) while not being logged in and not using basic authentication as in the issue, you are redirected to the login page but without thereturnPath
query parm. The redirect itself is done here https://github.com/umbraco/Umbraco-CMS/blob/v13/contrib/src/Umbraco.Web.BackOffice/Controllers/BackOfficeController.cs#L141 but I'm not sure how/where the hash part of the query is carried on on the client.