Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'core' package libdef types #1017

Closed
wants to merge 2 commits into from
Closed

Fix 'core' package libdef types #1017

wants to merge 2 commits into from

Conversation

ChrisRast
Copy link

Fixes #1016.

  • Disables skipLibCheck for 'core' package. (Note: if a packages has a libdef, it should also be disabled there.)
  • Fix issues created when overriding properties in interfaces.
  • Fix missing generic types for ImmMap type.
  • Fix functions types shallowEqual and mergeListValues.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Dec 11, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 3:26pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 3:26pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview Dec 11, 2023 3:26pm

@ChrisRast ChrisRast mentioned this pull request Dec 11, 2023
Closed
@ukrbublik
Copy link
Owner

Thanks for your PR!
I've merged your fixes as part of another PR (#1034)

@ukrbublik ukrbublik closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type conflict in core package since v6.4.1
2 participants
@ChrisRast @ukrbublik