Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the ipython-session profile to "concert_*session_name*" #503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MarcusZuber
Copy link
Member

@MarcusZuber MarcusZuber commented Aug 4, 2022

This creates and uses independent ipython session profiles for each concert session.
This helps to separates histories between sessions.

TODOs:

  • Delete profile folders together with the sessions
  • Test profile creation
  • Test profile deletion
  • Change concert.log to a rotating format

@MarcusZuber MarcusZuber self-assigned this Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Base: 87.75% // Head: 87.75% // No change to project coverage 👍

Coverage data is based on head (f719a32) compared to base (07762b4).
Patch has no changes to coverable lines.

❗ Current head f719a32 differs from pull request most recent head 362ea3c. Consider uploading reports for the commit 362ea3c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         115      115           
  Lines        7931     7931           
=======================================
  Hits         6960     6960           
  Misses        971      971           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tfarago
Copy link
Contributor

tfarago commented Aug 23, 2022

What does this actually do? Creates a profile for every session or just dumps history somewhere else?

@MarcusZuber
Copy link
Member Author

It creates one profile per Session (name).

@tfarago
Copy link
Contributor

tfarago commented Aug 23, 2022

I wonder if the session history should be cleaned up at some point. I can imagine concert rm session would delete the profile, what do you think?

@MarcusZuber
Copy link
Member Author

To delete them makes sense. I will add this.
I will also have a look if there is a way to somehow remove old histories (maybe like log rotate or similar...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants