Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow async import for Python < 3.8 #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfarago
Copy link
Contributor

@tfarago tfarago commented Jul 1, 2022

We can either do this or bump the minimum python version. If the former:

  • disable non-interactive top level await for Python < 3.8

@tfarago tfarago requested a review from MarcusZuber July 1, 2022 13:15
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #500 (f3b28a5) into master (07762b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         115      115           
  Lines        7931     7931           
=======================================
  Hits         6960     6960           
  Misses        971      971           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07762b4...f3b28a5. Read the comment docs.

Copy link
Member

@MarcusZuber MarcusZuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a running python3.7, but it looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants