-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add ability to write meta data #352
base: master
Are you sure you want to change the base?
Conversation
Finally someone has started 😄 We can put it to the experiment in a very loose way, why not. |
I also was thinking about somthing simmilar after I saw how many scans we already had produced... Also the possibility to add additional data, that is not created by concert, like sample discription, external filtration etc., would be helpfull. The folder for the file could be determined by the walker of the experiment. |
I might add that this is just a very rough draft concerning data @Threadmonkey is most interested in. I will update the PR comment with the most dire requirements. @MarcusZuber I did something along the lines some time ago in a separate branch (see 8a9aa2d) but to fully generalize that, we would serialize the state of the devices available in a session. Unfortunately, it is not very easy without relying on clutches like this. |
Some new insight:
|
This is pretty old but actually the idea was good and we should implement this, but after python 3. |
Most of this is already paritlally in the Short summary how it works currently: So I would suggest to add a second, more machine-readable output to the experiment, that puts all the properties into a json, xml or something similar. The the possibility to add arbitrary devices/parameters the output would also be nice. |
I just tried an early implementation in https://github.com/ufo-kit/concert/tree/new-metadata (I didn't want to compeltely overwrite this old branch). |
I think this #483 should solve this almost completely. Should we close this PR or do we need something in addition? |
What about the hdf5 point? Are we ever going to support that? |
Maybe. But then we should start first with a proper hdf5 (+nexus?) walker and ImageWriter. Putting there the data, that is currently put in the json, should then not be a major issue. |
PR and discussion about writing experiment meta data. Still not ready, need to decide where this should live (in an experiment itself?). Here some open issues