Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added commitlint for conventional commit linting #5133

Merged
merged 2 commits into from May 11, 2024
Merged

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented May 11, 2024

Please describe your changes

This PR adds commitlint to Tiptap which runs via a husky hook. It should help developers keep conventional commit messages in mind.

How did you accomplish your changes

  1. Added commitlint to the project with the @commitlint/config-conventional template
  2. Added a new husky hook commit-msg which runs said linting process

How have you tested your changes

I ran npx commitlint --from HEAD~5 --to HEAD --verbose to verify that we had faulty commit messages in the last 5 commit messages

How can we verify your changes

Try commit something :)

Remarks

nothing

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

no related issues

@bdbch bdbch requested a review from svenadlung as a code owner May 11, 2024 01:25
Copy link

netlify bot commented May 11, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit d2eda39
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/663ec90caa4bd60008bd0543
😎 Deploy Preview https://deploy-preview-5133--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch merged commit e992e70 into main May 11, 2024
14 checks passed
@bdbch bdbch deleted the commit-lint branch May 11, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant