Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to validate pasted links #5061

Merged
merged 3 commits into from May 24, 2024
Merged

Conversation

Nantris
Copy link
Contributor

@Nantris Nantris commented Apr 11, 2024

Also defaults validate option to val => !!val rather than undefined

Please describe your changes

Fix failure to validate pasted links (#5060)

How did you accomplish your changes

Add code which was missing to check pasted links are valid like all others

How have you tested your changes

I have not

How can we verify your changes

Probably manually. I assume automated tests do not cover this since this regression was able to sneak into 2.2.0

Remarks

Fixes #5060

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#5060

Also defaults validate to function rather than undefined
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 0040557
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6618642e7a0475000810858c
😎 Deploy Preview https://deploy-preview-5061--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nantris
Copy link
Contributor Author

Nantris commented Apr 11, 2024

These changes should also be backported to 2.2.x

@Nantris
Copy link
Contributor Author

Nantris commented Apr 11, 2024

@bdbch @svenadlung ready for review when you can

@Nantris
Copy link
Contributor Author

Nantris commented Apr 17, 2024

This change is essential to fix a breaking regression in 2.2.x and 2.3.x. Can anyone take a look?

Copy link

@loui7 loui7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nperez0111 nperez0111 merged commit e95140c into ueberdosis:main May 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants