Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): clean up constructor & extension setup in extension manager #5035

Merged
merged 4 commits into from May 14, 2024

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Apr 6, 2024

Please describe your changes

This PR restructures the code of the extension manager by:

  1. Moving the extension setup loop into it's own function cleaning up the constructor for better clarity and understanding
  2. Restructured the component event listener setup to first get all extension fields and afterwards binding the listeners from the extension fields

I also added a few comments to better describe what some functions are doing.

How did you accomplish your changes

See above

How have you tested your changes

Did a local test and all functionalities were behaving the same.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

@bdbch bdbch requested a review from svenadlung as a code owner April 6, 2024 11:14
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit be18898
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66435c8726ea9f0008d4d163
😎 Deploy Preview https://deploy-preview-5035--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nperez0111
nperez0111 previously approved these changes May 13, 2024
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdbch bdbch merged commit 6049985 into main May 14, 2024
3 checks passed
@bdbch bdbch deleted the extension-manager-refactor branch May 14, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants