fix: initially set editor object only on non-ssr environments #4864
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -99,7 +101,9 @@ export const useEditor = (options: Partial<EditorOptions> = {}, deps: Dependency | |||
| useEffect(() => { | |||
| let isMounted = true | |||
|
|
|||
| editorRef.current = new Editor(options) | |||
| if (!editorRef.current) { | |||
There was a problem hiding this comment.
Please take a look at #4579 if you get the chance. That pull request uses memo instead of a ref and also eliminates the double initialization that also causes issues (build failure). Best not to create the editor instance in an effect, but a memo instead; that way it gets created first render and after any deps array changes. The above PR also fixes the memory leak with the existing ref-based hook. Not a big deal to me either way if you want to just merge this PR in and abandon/close mine, but I would definitely recommend using memo. I am curious though if the types will be updated in a breaking change later, for those that extend the hook using Typescript or have ESLint rules for unnecessary null checks.
Also heads up, this is also similar to this draft PR https://github.com/ueberdosis/tiptap/pull/4858/files by @svenadlung , which has the same issue of double editor initialization.
Please describe your changes
This PR gets rid of the initial null render on non-ssr environments.
How did you accomplish your changes
We're doing a check on the window object to see if the current env is a browser environment.
Checklist