Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding first draft of JSDocs #4356

Merged
merged 8 commits into from May 11, 2024
Merged

docs: Adding first draft of JSDocs #4356

merged 8 commits into from May 11, 2024

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Aug 19, 2023

Please describe your changes

This PR adds tons of JSDocs for almost all Tiptap extensions excluding the rendering extensions (React, Vue 2 and Vue 3).

This is a draft for now until I feel happy about the amount of jsdocs and will make this PR ready for review as soon as I think we can throw the first batch of jsdocs out there.

@bdbch bdbch self-assigned this Aug 19, 2023
@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8ad57fd
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/663f64d2e6693700087c2c1e
😎 Deploy Preview https://deploy-preview-4356--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch marked this pull request as ready for review August 23, 2023 16:20
@bdbch bdbch requested a review from svenadlung as a code owner August 23, 2023 16:20
@bdbch
Copy link
Contributor Author

bdbch commented Aug 23, 2023

@svenadlung this would be ready for review for now. I think the next batch of js docs can come in isolated from this.

@bdbch
Copy link
Contributor Author

bdbch commented Dec 20, 2023

@svenadlung could we take a look at this as soon as possible? I spent a bit of time into this and don't want it to draft to far out of sync with the current branch. :)

svenadlung
svenadlung previously approved these changes Dec 20, 2023
Copy link
Contributor

@svenadlung svenadlung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Great work!

@bdbch bdbch merged commit b941eea into main May 11, 2024
12 of 13 checks passed
@bdbch bdbch deleted the bdbch/jsdocs branch May 11, 2024 12:30
@nperez0111
Copy link
Contributor

Fantastic PR here, really helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants