Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 2.2.x linkifies pasted text no matter what you do, even if you disable all options and remove all ProseMirror plugins #5060

Closed
1 of 2 tasks
Nantris opened this issue Apr 11, 2024 · 0 comments · Fixed by #5061
Closed
1 of 2 tasks

[Bug]: 2.2.x linkifies pasted text no matter what you do, even if you disable all options and remove all ProseMirror plugins #5060

Nantris opened this issue Apr 11, 2024 · 0 comments · Fixed by #5061
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@Nantris
Copy link
Contributor

Nantris commented Apr 11, 2024 •
edited

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.2.6

What’s the bug you are facing?

Pasting links cannot be disabled since 2.2.0 and above as it could be in 2.1.x.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

Excluding all ProseMirror plugins, setting linkOnPaste: false, autolink: false, and validate: () => false should prevent link pasting, but it has no effect at all. Links can be pasted and this behavior cannot be prevented so long as the Link extension is used.

Anything to add? (optional)

I suspect it was caused by this PR: eaee9c7

Specifically I suspect it's related to the changes to the addPasteRules code.

This issue could have been caught many months ago if attention were given to blocker issues, but we've been unable to upgrade past 2.1.x until today.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Apr 11, 2024
@Nantris Nantris mentioned this issue Apr 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Tiptap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failure to validate pasted links Nantris/tiptap
1 participant
@Nantris