Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lines and links to events calendar #596

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

Amyh11325
Copy link
Contributor

What

Make new lines and links show up on events calendar.

How

Run dompurify on user input from Google sheets to remove dangerous inputs
Wrap links with tags and replace new lines with

Use setDangerouslyInnerHtml to set description content

Test

Screen Shot 2023-02-13 at 8 43 07 PM

Copy link
Member

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to comment that I appreciate the usage of DOMPurify. 😎

Amyh11325 and others added 5 commits April 13, 2023 18:57
* refactored usage of isomorphic-dompurify into getStaticProps context
* updated some dependency management
* updated next.config.js to contain webpack config for DOMPurify dependencies in server-side rendering
@bliutech
Copy link
Member

bliutech commented Apr 29, 2023

Quick update. @Amyh11325 reached out to me and looped me in some of the issues with DOMPurify with Next.js builds. I managed to get those working in the above changes. :D

@bliutech
Copy link
Member

@ArshMalik02 Some of these action failures I don't think I can debug unless I get access to the Netlify console. The public details from the logs are not very helpful.

@ArshMalik02
Copy link
Contributor

@bliutech I and @JCamyre (deployment lead) will take a look at this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants