added a search bar filter #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcn56
requested changes
Mar 22, 2022
|
|
||
| return ( | ||
| <div> | ||
| <p>Filter projects</p> |
There was a problem hiding this comment.
Instead of a paragraph tag to filter projects, what if we used the placeholder property for the searchbar input to indicate that we can search for specific projects? It's less text for the reader but still conveys that it's a searchbar.
If you want, you can also add in a small magnifying glass icon as well kinda like what google does (or we can make that another bite-sized PR along with other styling stuff in the future)!
pages/projects.tsx
Outdated
| </div> | ||
| ); | ||
| }) | ||
| : <h1>No results found</h1> |
There was a problem hiding this comment.
As a general rule, we only have a single h1 on a page at any given time. Subheadings can be h2 and it's fine to have multiple h2 tags present on a page at once!
|
@ColbertX when you're ready for review, just press the re-request review button! |
matthewcn56
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can type into the search bar and the projects get filtered in real time. It searches for any project that contains the search term in the name, description, topic or the language. I mainly focused on implementing the functionality, so the styling could do with some work