Navigation bar update #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add transition on hover - add a different styling for this github button than other buttons - add border
- issue: when a button is clicked there was a blue outline - changes: declared box shadow as none for buttons
- added box-shadow: none; to the hamburger styling
snigdha-kansal
requested changes
Apr 27, 2024
There was a problem hiding this comment.
Great work, Audrey!
Few things that I noticed:
- There is a lot of spacing between the buttons for acm website, projects, contribute, and github on the nav bar. Would be great if we can reduce it.
- The blue border appears around the hamburger icon when it is clicked. Can we remove that using another
box-shadow: none? - The button for GitHub is a bit too rounded right now. I think it'd help to reduce the roundness. You can use the button that appears on clicking the hamburger icon as reference for this.
Also, can you update the pull request description to link the issue it resolves? Thanks!
I think once we have these down, we can merge this branch!
- make spacing smaller - make spacing between github button and other buttons more consistent
…ensource into navigation-bar-update
This was referenced Apr 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Old open source nav bar
ACM Website nav bar
Code