Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted ImageSelector.js to Typescript #1120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kYpranite
Copy link
Contributor

@kYpranite kYpranite commented Feb 7, 2024

Had pre-commit error about not having a defaultProp: I added one but not sure if it is best practice or deprecated.

Also npm installed type declaration for ReactModal

Copy link

netlify bot commented Feb 7, 2024

👷 Deploy request for sleepy-franklin-7a3e4c pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2363148

@mizlan
Copy link
Member

mizlan commented Mar 3, 2024

You can either rebase your changes atop the new master, or just redo the PR after resetting --hard to origin/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants