Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/results app user name #1488

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

jarvisraymond-uchicago
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago commented Feb 7, 2024

Jira Ticket: vadc-904

Notes

  • BE needs to provide Key / Value for user name using key userName
  • These lines need to be removed from HomeTable.jsx before merging:

import TableData from '../../../TestData/TableData'; // REMOVE THIS LINE!
data = TableData; // REMOVE THIS LINE!

Then run linter again (i.e. npm run eslint-new ) and test

Implementation
output

Storybook
output

New Features

  • Adds user name functionality to ResultsApp

…value for chart width scaling function to FULLSIZE_CHART_DEFAULT_NUM_BARS
Base automatically changed from feat/vadc_sprint04 to master March 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant