Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

autoCaps shouldn't be activated after ":" #101

Merged

Conversation

mymike00
Copy link
Contributor

this fixes #97
as for ubports/crossbuilder#27 I opened this PR just to make CI building this and test. I'll remove the draft state once tested and confirmed it does what I expect
Thanks

@mymike00
Copy link
Contributor Author

Just tested artifacts from jenkins: now autocaps is not activated after : (and space after that, obviously) as I was expecting.
Dunno if this has negative effects somewhere else. I hope it doesn't bu I'll continue testing this build on my daily driver...

@mymike00 mymike00 marked this pull request as ready for review October 15, 2019 14:31
Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see discussion in #97, whether this change is useful for most of the supported languages.

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it is much more common to not capitalize than to capitalize, at least in the languages represented by responding users. Let's do this!

@UniversalSuperBox UniversalSuperBox merged commit 614721e into ubports:xenial Nov 5, 2019
@mymike00 mymike00 deleted the autocaps-after-doublepoints branch November 6, 2019 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoCapitalization is activated also after :
2 participants