-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the website homepage #836
base: master
Are you sure you want to change the base?
Conversation
How easy would it be to let users click on the map to select and deselect hexes? And maybe in a way that would sync with the text box of given hexes? |
The text box and the map can certainly be synchronized to each other. Right now we need to remove a lot of deck.gl's example boilerplate to make that state code easier to follow. Selecting and deselecting hexes is possible but depends heavily on the exact logic for the selection interaction. Maybe we could use the approach @nrabinowitz mentioned to figure out what resolution of cell to select for a click? |
@ajfriend can you look into the license/snyk check and let me know what's going on? I do not have access to that report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's going on with the /example
code? Doesn't seem to be H3-related.
website/src/examples/home-demo.js
Outdated
lineWidthMinPixels: 3, | ||
highPrecision: true, | ||
})] : [ | ||
new H3HexagonLayer({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you intending to implement support for finer resolutions (viewport-only)? Or is the idea to just show the first 3 resolutions? If it's the latter, this might actually be simpler and more performant just with Mapbox/Maplibre styles, rather than Deck...
Oh, its "snyk". Not "synk". :/ |
Amazing! This is super exciting, and the screenshots look great! I'll try building locally to test things out in the next few days. Quick thoughts just based off of the screenshots: Of the information you're displaying in each cell, I'd actually consider the following to be fairly "advanced" H3 content that the average user probably wouldn't know what to make of:
For a maximally-welcoming front-page display, I wonder if we'd want to limit it down to just the basics of what might be the most relevant to a new user:
Maybe a separate view could provide more of the advanced cell stats, or just reordering or deprioritizing the advanced stuff? Also, all this info might be fine, this is just my first impression :) |
I agree these things can move off to a new page that acts as the official "index inspector". The home page should focus on:
Things that will move to another page include:
|
Some notes from reviewing this live:
|
Here are some work in progress screenshots:
Goals are for the h3geo.org home page to be more informative and useful.
I adapted the code from deck.gl. There is still a lot of extra abstraction that can be cleaned up and removed here. We will also need to substitute appropriate basemap keys for this website.