Update workflow status badge to use grpc enum #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Assem-Hafez
commented
May 15, 2024
Assem-Hafez
commented
- changing enum for workflow status tag to use the values from GRPC response (this is a temp state until we work on data transformation layer)
- added "use client" to the status tag to be able to use it in server components.
adhityamamallan
approved these changes
May 16, 2024
Assem-Uber
pushed a commit
to Assem-Hafez/cadence-web
that referenced
this pull request
May 16, 2024
* Update workflow status badge to use grpc enum * update unit tests to use the type too
Assem-Uber
pushed a commit
that referenced
this pull request
May 22, 2024
* Update workflow status badge to use grpc enum * update unit tests to use the type too * workflow page header * lint fix * add cluster to the url navigation * remove formate close-event-result * fix mock linting issue * workflow page header * Update workflow status badge to use grpc enum (#568) * Update workflow status badge to use grpc enum * update unit tests to use the type too * remove unused format closed event file * fix typo * move svg after components * fixed the mock for tabs config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.