Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Page Filters component #561

Merged
merged 17 commits into from
May 24, 2024
Merged

Add Page Filters component #561

merged 17 commits into from
May 24, 2024

Conversation

adhityamamallan
Copy link
Contributor

Add reusable Search Bar component with Filters and Clear Filters button

Assem-Uber
Assem-Uber requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Assem-Uber Assem-Uber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this component won't work with the existing way of configurations and it is missing the responsiveness enhancements that already exist.

Lets have a discussion for combining the approaches

src/components/search-bar/search-bar.tsx Outdated Show resolved Hide resolved
src/components/search-bar/search-bar.tsx Outdated Show resolved Hide resolved
src/components/search-bar/search-bar.tsx Outdated Show resolved Hide resolved
src/components/search-bar/search-bar.tsx Outdated Show resolved Hide resolved
src/components/search-bar/search-bar.styles.ts Outdated Show resolved Hide resolved
@adhityamamallan adhityamamallan changed the title Add Search Bar filters component Add Page Filters component May 22, 2024
Assem-Uber
Assem-Uber requested changes May 22, 2024
View reviewed changes
src/components/page-filters/page-filters.tsx Outdated Show resolved Hide resolved
src/components/page-filters/page-filters.tsx Show resolved Hide resolved
src/components/page-filters/page-filters.tsx Outdated Show resolved Hide resolved
src/components/page-filters/page-filters.styles.ts Outdated Show resolved Hide resolved
@adhityamamallan adhityamamallan merged commit dc95aab into release/4.0.0 May 24, 2024
5 checks passed
Assem-Uber pushed a commit to Assem-Hafez/cadence-web that referenced this pull request May 24, 2024
@adhityamamallan @Assem-Hafez
Add Page Filters component (uber#561)
890323e 
* Add reusable Search Bar component with Filters and Clear Filters button
@adhityamamallan adhityamamallan deleted the filters branch May 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adhityamamallan @Assem-Uber