WIP: Implement new groupchats #1271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhert0
force-pushed
the
new_groupchats
branch
2 times, most recently
from
b079ea2
to
a940466
Compare
ghost
suggested changes
Apr 26, 2020
Comment on lines
-77
to
+80
| snprintf((char *)g->name, sizeof(g->name), "Groupchat #%u", group_number); | ||
| g->name_length = strnlen(g->name, sizeof(g->name) - 1); | ||
| g->name_length = snprintf(g->name, sizeof(g->name), "Groupchat #%u", group_number); | ||
| if (g->name_length >= sizeof(g->name)) { | ||
| g->name_length = sizeof(g->name) - 1; | ||
| } |
src/layout/group.c
Outdated
| .style_toggle = BM_SWITCH_TOGGLE, | ||
| .style_icon_off = BM_NO, | ||
| .style_icon_on = BM_YES, | ||
| .switch_on = true, //private group by default |
Comment on lines
-28
to
+30
| edit_group_topic; | ||
| edit_group_topic, | ||
| edit_group_name; |
There was a problem hiding this comment.
Small note: If you added the variable between chat_msg_group and group_topic, you would have not touched group_topic needlessly (git blame), and the diff would be more trivial.
And I think I actually prefer not to touch that line.
src/tox.c
Outdated
| * param2: audio call or not | ||
| * data: group name | ||
| */ | ||
| // TODO: readd checking if its an audio call later when it is supported |
There was a problem hiding this comment.
If you write re-add, it won't look like a typo of read.
src/tox.c
Outdated
| free(data); | ||
|
|
||
| if (error) { | ||
| LOG_ERR("Toxcore", "Error sending groupchat message... %u" , error); | ||
| LOG_ERR("Toxcore", "Error sending message to groupchat %u. Erorr number: %u", param1, error); |
src/tox_callbacks.c
Outdated
Comment on lines
175
to
172
| LOG_ERR("Tox Callbacks", "Could not join group with type: %u", type); | ||
| LOG_ERR("Tox Callbacks", "Could not join group with type"); |
There was a problem hiding this comment.
Did you not mean to delete the " with type", too?
|
Thanks for starting this! Try to keep your log clean from the start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is