Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B4/for 2024 07 am65 cpsw mdio 1.0 #491

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rogerq
Copy link
Contributor

@rogerq rogerq commented Feb 19, 2024

NOTE: Only for CI testing

Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://u-boot.readthedocs.io/en/latest/develop/sending_patches.html

The only exception to this is in order to trigger a CI loop on Azure prior
to posting of patches.

Hi,

This converts cpsw-mdio into a proper Driver Model
driver and introduces the new Config symbol CONFIG_MDIO_TI_CPSW.

It also cleans up the am65-cpsw driver so it porperly uses
the DM PHY interface.

It does not convert the legacy cpsw and keystone-net drivers.

Tested on AM64-EVM and AM335x BeagleBone.
AM64-EVM network doesn't work at 1G but only at 100M. This
limitation exists prior to this patch.

CI tests: u-boot#490

# Describe the purpose of this series. The information you put here
# will be used by the project maintainer to make a decision whether
# your patches should be reviewed, and in what priority order. Please be
# very detailed and link to any relevant discussions or sites that the
# maintainer can review to better understand your proposed changes. If you
# only have a single patch in your series, the contents of the cover
# letter will be appended to the "under-the-cut" portion of the patch.

# Lines starting with # will be removed from the cover letter. You can
# use them to add notes or reminders to yourself. If you want to use
# markdown headers in your cover letter, start the line with ">#".

# You can add trailers to the cover letter. Any email addresses found in
# these trailers will be added to the addresses specified/generated
# during the b4 send stage. You can also run "b4 prep --auto-to-cc" to
# auto-populate the To: and Cc: trailers based on the code being
# modified.

To: Joe Hershberger <joe.hershberger@ni.com>
To: Ramon Fried <rfried.dev@gmail.com>
To: Tom Rini <trini@konsulko.com>
To: <nm@ti.com>
Cc: <srk@ti.com>
Cc: <s-vadapalli@ti.com>
Cc: <vigneshr@ti.com>
Cc: <mripard@kernel.org>
Cc: <dannenberg@ti.com>
Cc: <r-gunasekaran@ti.com>
Cc: <danishanwar@ti.com>
Cc: <u-boot@lists.denx.de>
Signed-off-by: Roger Quadros <rogerq@kernel.org>

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
  "series": {
    "revision": 1,
    "change-id": "20240216-for-2024-07-am65-cpsw-mdio-e3c15b297442",
    "prefixes": []
  }
}
Some platforms have bus level Reset controlled
by a GPIO line. If available then handle bus reset
via GPIO.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
Add a new Kconfig symbol MDIO_TI_CPSW for the CPSW MDIO
driver and build it with proper DM support if enabled.

If MDIO_TI_CPSW is not enabled then we continue to
behave like before.

Clean up MDIO custom handling in am65-cpsw and use
dm_eth_phy_connect() to get the PHY.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
rogerq added a commit to rogerq/u-boot that referenced this pull request Feb 27, 2024
Hi,

This converts cpsw-mdio into a proper Driver Model
driver and introduces the new Config symbol CONFIG_MDIO_TI_CPSW.

It also cleans up the am65-cpsw driver so it porperly uses
the DM PHY interface.

It does not convert the legacy cpsw and keystone-net drivers.

Tested on AM64-EVM and AM335x BeagleBone.
AM64-EVM network doesn't work at 1G but only at 100M. This
limitation exists prior to this patch.

CI tests: u-boot#491

# Describe the purpose of this series. The information you put here
# will be used by the project maintainer to make a decision whether
# your patches should be reviewed, and in what priority order. Please be
# very detailed and link to any relevant discussions or sites that the
# maintainer can review to better understand your proposed changes. If you
# only have a single patch in your series, the contents of the cover
# letter will be appended to the "under-the-cut" portion of the patch.

# Lines starting with # will be removed from the cover letter. You can
# use them to add notes or reminders to yourself. If you want to use
# markdown headers in your cover letter, start the line with ">#".

# You can add trailers to the cover letter. Any email addresses found in
# these trailers will be added to the addresses specified/generated
# during the b4 send stage. You can also run "b4 prep --auto-to-cc" to
# auto-populate the To: and Cc: trailers based on the code being
# modified.

To: Joe Hershberger <joe.hershberger@ni.com>
To: Ramon Fried <rfried.dev@gmail.com>
To: Tom Rini <trini@konsulko.com>
To: <nm@ti.com>
Cc: <srk@ti.com>
Cc: <s-vadapalli@ti.com>
Cc: <vigneshr@ti.com>
Cc: <mripard@kernel.org>
Cc: <dannenberg@ti.com>
Cc: <r-gunasekaran@ti.com>
Cc: <danishanwar@ti.com>
Cc: <u-boot@lists.denx.de>
Signed-off-by: Roger Quadros <rogerq@kernel.org>

---
Changes in v2:
- Fix build if DM_GPIO not set.
- Fix build on platforms that don't define <asm/gpio.h>
- Link to v1: https://lore.kernel.org/r/20240219-for-2024-07-am65-cpsw-mdio-v1-0-afe9aaba5801@kernel.org

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
  "series": {
    "revision": 2,
    "change-id": "20240216-for-2024-07-am65-cpsw-mdio-e3c15b297442",
    "prefixes": [],
    "history": {
      "v1": [
        "20240219-for-2024-07-am65-cpsw-mdio-v1-0-afe9aaba5801@kernel.org"
      ]
    }
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant