Limited redirect #1637
Open
Limited redirect #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I took the list of redirection detection from here. I tested with windows, ios and android. |
|
Yeah you are supposed to turn off all data when using captive portals but adding a filter is a good idea problem is keeping up with it there are no standards and they all randomly change |
|
Add custom or callout for captive checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I connect to wifimanager from my windows, it generates many requests (eg wpad/wpad.dat, autodiscover, etc.).
All these requests end up being served by wifimanager twice: once for redirect and a second time as 404.
It's often so consuming for asyncweb that the esp32 ends up crashing and my pc disconnected.
It's often better from my mobile where I get less extra requests.
However, I believe we shouldn't redirect these extra requests in the first place. With this change, I see no more crashes nor disconnections.