Only reconnect if WiFi updated #1555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If only the parameters have been updated then don't try to reconnect on save. Otherwise _ssid and _pass are blank (because "placeholder" input attribute is used) and the connection will fail.
|
still a problem in the latest code |
|
What browser? placeholders should not be submitted in inputs |
|
Yes, exactly, the placeholder is not submitted, and therefore WiFiManager uses the returned (blank) SSID and password to reconnect. This causes the connection to fail. My patch makes it so that if the SSID and password are not changed it will not try to reconnect with blank Tested with Chromium 110.0.5481.177 |
|
If its blank then it shouldnt be connecting at all |
|
Is that the intended behavior? Every time that you go into the settings page you need to type in the ssid and password again, even if the placeholder is correct? |
|
No, I will take a look, something else seems to be broken also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only the parameters have been updated then don't try to reconnect on save. Otherwise
_ssidand_passare blank (because "placeholder" input attribute is used) and the connection will fail.