athena-tu-darmstadt-thesis:0.1.0 #639
Conversation
| repository = "https://github.com/JeyRunner/tuda-typst-templates" | ||
| keywords = ["TU Darmstadt", "Technische Universität Darmstadt", "Bachelorthesis", "Masterthesis", "Bachelorarbeit", "Masterarbeit", "thesis"] | ||
| categories = ["thesis"] | ||
| exclude = ["tests", "example_tudapub.pdf"] |
There was a problem hiding this comment.
I think example_tudapub.typ could be excluded too, as it not really useful to have an example file in the archive that the compiler downloads when installing the package.
There was a problem hiding this comment.
Yes, you are right.
Btw, is the point excluded PDFs or README images, if any, but not the LICENSE meant as in just add all excluded files to exclude in the typst.toml or also not include these files in this repo?
There was a problem hiding this comment.
The former, although you are free to choose which excluded files you deem important enough to the package to include them in your PR.
| // This function gets your whole document as its `body` and formats it. | ||
| #let tudapub( | ||
| title: [Title], | ||
| title_german: [Title German], |
There was a problem hiding this comment.
Even if not mandatory, it is recommended to use kebab-case names (at least for user facing functions and their arguments). If you prefer to keep snake_case everywhere, it is also possible to merge it as is.
There was a problem hiding this comment.
Yes. I am planning to change this in a future version.
But for the first version, I want to keep the names as-is, since I and at least one other person use the package locally with the current snake_case. I want to ensure that the local versions can be replaced with the universe version without breaking anything.
packages/preview/athena-tu-darmstadt-thesis/0.1.0/templates/tudapub/fonts/download_fonts.sh
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,8 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Same remark for this file (and more generally the whole logos directory)
reknih
force-pushed
the
main
branch
6 times, most recently
from
92aab43
to
d06d87c
Compare
|
Thanks for the feedback, I removed the redundant files and excluded the additional example file. |
I am submitting
Description: This is an unofficial thesis template for the University TU Darmstadt (Technische Universität Darmstadt) following the university design guidelines while imitating the existing official latex template.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE