chuli-cv:0.1.0 #635
Merged
chuli-cv:0.1.0 #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegaanz
reviewed
May 13, 2024
| link: "#" | ||
| ), | ||
| ), | ||
| profile-picture: image("media/avatar.png") |
There was a problem hiding this comment.
The media directory won't be copied to projects using this template, so this wouldn't work. If you want to include an example image, it should go in the template directory (it can be in a dedicated sub-directory if you want).
There was a problem hiding this comment.
I think I might have missed something. media folder is already located inside template folder, isn't that how it should be?
There was a problem hiding this comment.
Yes, my bad, you are right.
| #letter_footer( | ||
| name: "Faye Valentine", | ||
| ) | ||
| #letter_signature(image("/media/signature.jpeg", width: 25%)) |
elegaanz
changed the title
|
Thanks for the update, everything looks good now :) I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE