Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv: v0.1.0 (new) #631

Merged
merged 3 commits into from May 16, 2024
Merged

dotenv: v0.1.0 (new) #631

merged 3 commits into from May 16, 2024

Conversation

chillcicada
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description: Load environment variables from a .env file.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission :) I have two remarks:

  • first, the name is too descriptive of what the package does (see the "Naming" section here. Could you please come up with an alternative name? It can just be an adjective or a suffix/prefix added to dotenv.
  • I also think that generated example files should not be included in this repository, as they can easily be re-created if needed. Could you please delete them? (this remark does not apply to /example.png as it is needed for your README to render correctly on Typst Universe).

Other than that and the comment below, it should be good to merge.

Comment on lines 8 to 9
homepage = "https://github.com/chillcicada/typst-dotenv#readme"
repository = "https://github.com/chillcicada/typst-dotenv"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two links feel redundant, I think having only repository would be less confusing.

@reknih reknih force-pushed the main branch 6 times, most recently from 92aab43 to d06d87c Compare May 15, 2024 10:12
@elegaanz elegaanz merged commit c6b3bd3 into typst:main May 16, 2024
1 check passed
@elegaanz
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants