Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supercharged-dhbw:1.0.0 #621

Merged
merged 7 commits into from May 14, 2024
Merged

supercharged-dhbw:1.0.0 #621

merged 7 commits into from May 14, 2024

Conversation

DannySeidel
Copy link
Contributor

@DannySeidel DannySeidel commented May 6, 2024

I am submitting

  • a new package
  • an update for a package

Unofficial thesis template for DHBW using the existing guidelines to achieve consistent looks.
The template contains options to configure different settings like authors or what pages to show.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • exclude PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@reknih
Copy link
Member

reknih commented May 8, 2024

Hey there, thank you for your submission. According to our guidelines, the package can only have the descriptive name dhbw-thesis if it is officially endorsed by DHBW. Otherwise, you will need to add a non-descriptive part (like an adjective) to the package name to allow for other implementations of the style.

If you are a full-time staff member (e.g. Professor, Academic Administrator) of DHBW or one such staff member endorses this package, please send an email to hello@typst.app using your or their institutional mail to verify this. Otherwise, we will ask you to update the package name to include some non-descriptive part so we can proceed to merge this.

@DannySeidel DannySeidel changed the title dhbw-thesis:1.0.0 supercharged-dhbw:1.0.0 May 8, 2024
@DannySeidel
Copy link
Contributor Author

Hey @reknih, I updated the naming.

Just out of curiosity, is it possible to still change the naming at a later time?

@DannySeidel
Copy link
Contributor Author

Hope I now change the naming everywhere 🙏🏻

@DannySeidel
Copy link
Contributor Author

This should be it now 😅

Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no way for a package to ship fonts, putting them in a folder as you did won't work. Can you please delete the fonts folder, and put a link in your README where users of the package can download the required fonts if they don't have them?

packages/preview/supercharged-dhbw/1.0.0/lib.typ Outdated Show resolved Hide resolved
@DannySeidel
Copy link
Contributor Author

I refactored the usage of the bib file and added font installation instructions. The changes should now be ready for merging.

@elegaanz
Copy link
Contributor

Thank you!

@elegaanz elegaanz merged commit 21d3517 into typst:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants