Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aero-check:0.1.0 #591

Merged
merged 7 commits into from May 13, 2024
Merged

aero-check:0.1.0 #591

merged 7 commits into from May 13, 2024

Conversation

TomVer99
Copy link
Contributor

@TomVer99 TomVer99 commented Apr 25, 2024

I am submitting

  • a new package
  • an update for a package

Description: This is a template which is intended to be used to create checklists in a style that is inspired by aviation.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@TomVer99
Copy link
Contributor Author

I have not ticked selected a name that isn't the most obvious or canonical name for what the package does yet, as I am not sure the name suffices. I think the name is fine, but I would like some feedback first if possible.

Thanks

@laurmaedje laurmaedje added the new A new package submission. label Apr 29, 2024
Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small remark about naming conventions, but you can ignore it if you want.
For the name, I feel like it doesn't meet the criteria, too. it would be better if you could propose something else.
Thanks :)

packages/preview/aviation-style-checklist/0.1.0/lib.typ Outdated Show resolved Hide resolved
packages/preview/aviation-style-checklist/0.1.0/lib.typ Outdated Show resolved Hide resolved
@TomVer99
Copy link
Contributor Author

TomVer99 commented May 5, 2024

@elegaanz would the name "AeroCheck" be good?

@elegaanz
Copy link
Contributor

elegaanz commented May 6, 2024

Yes, perfect.

@TomVer99 TomVer99 changed the title aviation style checklist:0.1.0 aero-check:0.1.0 May 6, 2024
@TomVer99
Copy link
Contributor Author

TomVer99 commented May 6, 2024

Should be ready now 😄

@TomVer99 TomVer99 requested a review from elegaanz May 7, 2024 22:49
Copy link
Contributor

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Everything looks good, but an import in the README.

packages/preview/aero-check/0.1.0/README.md Outdated Show resolved Hide resolved
fix readme example import

Co-authored-by: Ana Gelez <ana+github@gelez.xyz>
@TomVer99 TomVer99 requested a review from elegaanz May 8, 2024 09:33
@elegaanz
Copy link
Contributor

Thank you!

@elegaanz elegaanz merged commit 574a5c2 into typst:main May 13, 2024
1 check passed
@TomVer99
Copy link
Contributor Author

@elegaanz thank you for the review! And sorry for the hassle 😅 . Next time ill do it all correctly the first time.

@elegaanz
Copy link
Contributor

No worries, it is hard to get everything right on the first try 😄 That's what the review process is here for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants