kinase 0.1.0 #590
kinase 0.1.0 #590
Conversation
| authors = ["Lennart Schuster"] | ||
| license = "MIT" | ||
| description = "Easy styling for different link types like mails and urls." | ||
| exclude = ["docs/manual.pdf", "ressources/example.png"] |
There was a problem hiding this comment.
I think docs & resources could be excluded completely. ressources should likely also be resources (typo).
There was a problem hiding this comment.
I think docs & resources could be excluded completely.
ressourcesshould likely also beresources(typo).
Changed it.
There was a problem hiding this comment.
It still says ressources with two s, is it intentional?
There was a problem hiding this comment.
Nah english is the only language to spell it that way, I fixed it.
Typo on my end. The package is named after the enzyme kinase. I also changed the title of the pull request to match the case. |
|
|
||
|
|
||
| ```typ | ||
| #import "@preview/link-style:0.0.1" |
There was a problem hiding this comment.
I think that import uses an old name and version and should be updated.
packages/preview/kinase/README.md
Outdated
| @@ -0,0 +1,27 @@ | |||
| # Kinave | |||
There was a problem hiding this comment.
There should only be a sub-folder per version in this directory, so I think you should delete this file.
| @@ -0,0 +1,16 @@ | |||
| #import "../bib.typ": * | |||
There was a problem hiding this comment.
I think the renaming of the directory didn't go as expected, the old one still exists here.
| @@ -0,0 +1,16 @@ | |||
| #import "../bib.typ": * | |||
There was a problem hiding this comment.
Ideally, this import should not be relative but use the package specification. If you want to keep it relative, it should probably be ../lib.typ.
| #import "../bib.typ": * | |
| #import "@preview/kinase:0.1.0": * |
|
The issues should be fixed, thanks for being so thorough. |
reknih
force-pushed
the
main
branch
6 times, most recently
from
92aab43
to
d06d87c
Compare
|
Thank you :) |
I am submitting
Description: This packages allows the easy styling of document links. While Typst produces correct output for internal and external links, there is no easy way to style those. To achieve this the user can set styling rules for different keys. Keys are regex or strings. The package includes regex helpers for mails, phone numbers and urls.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE