Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimal-ovgu-thesis:0.1.0 #563

Merged
merged 8 commits into from May 17, 2024
Merged

optimal-ovgu-thesis:0.1.0 #563

merged 8 commits into from May 17, 2024

Conversation

v411e
Copy link
Contributor

@v411e v411e commented Apr 18, 2024

I am submitting

  • a new package
  • an update for a package

Description: This is a thesis template that can be used by students of the Otto von Guericke University Magdeburg.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@laurmaedje laurmaedje added the new A new package submission. label Apr 19, 2024
└── thesis.typ // Thesis template
```

## Logos on the title page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the logo assets intentionally part of the template that will be cloned into the user's project rather than part of the package, so that they can easily be swapped? If they are always the same, it might be user-friendlier to just ship them behind the scenes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was intentional for exact this reason to make it easier for users to swap them out. But I am unsure if it's correct license wise or if it'd be better to just provide links for the users to download them themselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just contacted the office at ovgu and asked for the license permission

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let me know once this is ready for merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the logo assets with questionable licenses. This should be ready now @laurmaedje . Thanks for reviewing it!

@laurmaedje laurmaedje added the waiting-on-author Pull request waits on author label Apr 30, 2024
@reknih reknih force-pushed the main branch 6 times, most recently from 92aab43 to d06d87c Compare May 15, 2024 10:12
v411e and others added 4 commits May 16, 2024 19:21
Co-authored-by: Laurenz <laurmaedje@gmail.com>
Co-authored-by: Laurenz <laurmaedje@gmail.com>
@elegaanz
Copy link
Contributor

Thanks :)

@elegaanz elegaanz merged commit 302931b into typst:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission. waiting-on-author Pull request waits on author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants