Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flatMapOrKeep to Monad #4602

Merged
merged 1 commit into from
May 25, 2024
Merged

Add flatMapOrKeep to Monad #4602

merged 1 commit into from
May 25, 2024
+28 −2

Conversation

jozic
Copy link
Contributor

@jozic jozic commented May 13, 2024

follow up to #4582

@jozic jozic marked this pull request as ready for review May 13, 2024 03:38
@jozic
Copy link
Contributor Author

jozic commented May 18, 2024

@johnynek @satorg @danicheg
Could you please review this?
You folks were reviewing mapOrKeep PR, so hopefully this one should be easy to follow. Thank you!

satorg
satorg approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

danicheg
danicheg approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@satorg satorg merged commit a1fab57 into typelevel:main May 25, 2024
16 checks passed
@jozic jozic deleted the monad.flatmaporkeep branch May 25, 2024 13:06
@armanbilge armanbilge mentioned this pull request May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@satorg satorg satorg approved these changes

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jozic @rossabaker @satorg @danicheg